Mercurial > urweb

diff src/sqlcache.sml @ 2259:6951a645ccdf
Fix effectfulness registration toy cache.
author: Ziv Scully <ziv@mit.edu>
date: Sun, 27 Sep 2015 17:24:57 -0400
parents: b1ba35ce2613
children: 03b10c7fab9a
--- a/src/sqlcache.sml	Sun Sep 27 17:02:14 2015 -0400
+++ b/src/sqlcache.sml	Sun Sep 27 17:24:57 2015 -0400
@@ -41,6 +41,8 @@
                                       "urlifyBool_w",
                                       "urlifyChannel_w"]
     in
+        (* ASK: nicer way than using [Settings.addEffectful] for each Sqlcache
+           function? Right now they're all always effectful. *)
         fn (m, f) => Settings.isEffectful (m, f)
                      andalso not (m = "Basis" andalso SS.member (okayWrites, f))
     end
@@ -807,12 +809,15 @@
  fn Pure f => f ()
   | Impure e => e
 
+(* TODO: pick a number. *)
+val sizeWorthCaching = 5
+
 fun makeCache (env, exp', index) =
     case typOfExp' env exp' of
         NONE => NONE
       | SOME (TFun _, _) => NONE
       | SOME typ =>
-        if expSize (exp', dummyLoc) < 5 (* TODO: pick a number. *)
+        if expSize (exp', dummyLoc) < sizeWorthCaching
         then NONE
         else case List.foldr (fn ((_, _), NONE) => NONE
                                | ((n, typ), SOME args) =>